Simplify builds by removing Hash::Merge
Closed this issue · 2 comments
petdance commented
Hash::Merge is used in only one place, in t/01-detect.t. It's used to combine two hashrefs:
my $all_tests = merge( $tests, $more_tests );
However, there is no overlap between $tests
and $more_tests
, so Hash::Merge isn't necessary, and could just be:
my $all_tests = { %$tests, %$more_tests };
This was prompted by HTTP::BrowserDetect not installing for me in a Docker container build. Hash::Merge fails to install. I know that the failure of Hash::Merge isn't HTTP::BrowserDetect's problem, but I figure simplifying its module usage could be a good thing.
petdance commented
Nice, thank you.
oalders commented
Should be on CPAN shortly.