oalders/http-browserdetect

Issues warnings on "Safari/12x.x"

andrewmoise opened this issue · 3 comments

For some reason I have this entry in my apache logs:

24.62.134.187 - - [03/Aug/2014:02:02:52 -0600] "GET /HNAP1/ HTTP/1.1" 404 9297 "http://69.195.78.37/" "Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-us) AppleWebKit/xxx.x (KHTML like Gecko) Safari/12x.x"

When HTTP::BrowserDetect 1.72-1 from Debian encounters that line, it says:

Use of uninitialized value $version in split at /usr/share/perl5/HTTP/BrowserDetect.pm line 1270, line 12305.
Use of uninitialized value $minor in substitution (s///) at /usr/share/perl5/HTTP/BrowserDetect.pm line 1272, line 12305.
Use of uninitialized value $minor in concatenation (.) or string at /usr/share/perl5/HTTP/BrowserDetect.pm line 1273, line 12305.
Argument "." isn't numeric in addition (+) at /usr/share/perl5/HTTP/BrowserDetect.pm line 1273, line 12305.
Use of uninitialized value $major in addition (+) at /usr/share/perl5/HTTP/BrowserDetect.pm line 1208, line 12305.

That log entry is fairly obviously something odd that's not worth worrying about too much, but still it would be better if HTTP::BrowserDetect didn't issue warnings about it (just silently reported it as an unknown version or something).

Thanks for your help.

That UA actually comes from a particular computer worm :)

Right, I figured it was something that wasn't a real user I had to worry about :-). But, it would be nice if the library also knew to ignore it, no?

But, it would be nice if the library also knew to ignore it, no?

Yea, I'm not disagreeing with you there :) Just noting down where the UA came from, mainly to know it's not a fluke and seems to be a "real UA"