oantolin/icomplete-vertical

Bleeding prompt

Closed this issue · 6 comments

minad commented

Icomplete-vertical has the same prompt bleeding issue as Selectrum had. See radian-software/selectrum#235. @clemera fixed this in radian-software/selectrum#413.

oantolin commented

OK, it seems it does suffer from the bleeding prompt problem:

(completing-read (propertize "Candidates: " 'face '(:background "purple"))
                 (list
                  (propertize "GNU" 'display "some-prefix: GNU")
                  (propertize "Emacs" 'display "other-prefix: Emacs")))

Now I'll go read the fix.

oantolin commented

Ah, OK, it's just about flattening the display properties into the string. I'll just steal @clemera's function, then.

minad commented

Thanks for the fix!

oantolin commented

I just realized that now icomplete-vertical doesn't have this bug but icomplete still does... 🙄

minad commented

Have fun reporting it upstream! Btw, there is also a recursive icomplete bug, where Icomplete does not update the display, when pressing M-x C-x o M-x C-g (Selectrum had that bug too, but @clemera just fixed it). You may also want to fix that in icomplete-vertical only 😆

clemera commented

@oantolin Maybe post another message to https://debbugs.gnu.org/cgi/bugreport.cgi?bug=46177 and CC Eli in the thread there? I forgot to mention that and that could be more convincing example for him that it might be worth looking into it.