[Bug] void-variable display
rprimus opened this issue · 8 comments
Tue Feb 9 10:04:34 GMT 2021
Since 1372ef0 I am getting the following error (in the minibuffer) when using the minibuffer:
Error in post-command-hook (icomplete-post-command-hook): (void-variable display)
Disabling icomplete-vertical allows normal operation.
What version of Emacs are you using?
In order to use if-let* you need (eval-when-compile (require 'subr-x)).
Tue Feb 9 12:53:56 GMT 2021
System info:
ProductName: Mac OS X
ProductVersion: 10.15.7
BuildVersion: 19H512
"GNU Emacs 27.1 (build 1, x86_64-apple-darwin19.6.0, Carbon Version 162 AppKit 1894.6) of 2020-11-15"
icomplete-vertical-20210208.130/
In order to use
if-let*you need(eval-when-compile (require 'subr-x)).
Thanks @basil-conto! Most of my packages do, I forgot this one doesn't. And I only tested on my system which has many common libraries loaded all the time.
I'm not sure the issue @basil-conto pointed out is actually the problem here, but I fixed that. c7d96c5
Please test, @rprimus.
@oantolin I wonder if you would see the problem via flycheck/flymake if you enable this package linter. I am having this on all the time when editing lisp packages and haven't seen downsides, except that it is slow when you open files like org.el. But this is something I only do for benchmarking 😆 well and looking up functions sometimes.
Tue Feb 9 14:24:12 GMT 2021
Please test
The error message is gone.
Just FYI - these were the errors/warnings when icomplete-vertical was updated:
In icomplete-vertical--display-string:
icomplete-vertical.el:171:44:Warning: ‘(display (get-text-property pos
'display str))’ is a malformed function
icomplete-vertical.el:178:26:Warning: reference to free variable ‘display’
In end of data:
icomplete-vertical.el:349:1:Warning: the function ‘if-let*’ is not known to be
defined.
Out of the three error messages, you picked the least informative one to put in the title! 😆 I'm lucky @basil-conto was around to figure this out.