oauth-xx/oauth-ruby

Hardcoded old em-http-request dependency

voxik opened this issue · 2 comments

voxik commented

oauth-ruby/oauth.gemspec

Line 37 in d453cee

spec.add_development_dependency("em-http-request", "0.2.11")

This version of em-http-request was released 10 years ago. No wonder that running the test suite against more recent version fails:

  1) Error:
EmHttpRequestProxyTest#test_request_proxy_works_with_post_body_params_with_correct_content_type:
ArgumentError: wrong number of arguments (given 1, expected 2)
    /usr/share/gems/gems/em-http-request-1.1.7/lib/em-http/client.rb:27:in `initialize'
    /builddir/build/BUILD/oauth-0.5.5/usr/share/gems/gems/oauth-0.5.5/test/units/test_em_http_request_proxy.rb:99:in `new'
    /builddir/build/BUILD/oauth-0.5.5/usr/share/gems/gems/oauth-0.5.5/test/units/test_em_http_request_proxy.rb:99:in `create_client'
    /builddir/build/BUILD/oauth-0.5.5/usr/share/gems/gems/oauth-0.5.5/test/units/test_em_http_request_proxy.rb:108:in `create_request_proxy'
    /builddir/build/BUILD/oauth-0.5.5/usr/share/gems/gems/oauth-0.5.5/test/units/test_em_http_request_proxy.rb:24:in `test_request_proxy_works_with_post_body_params_with_correct_content_type'

BTW I am not really em-http-request user. I have just randomly tried to enable this part of test suite for OAuth package on Fedora.

pboling commented

@voxik Please try latest master! Should be fixed and on latest em-http-reqest now. Closed by #176

voxik commented

I have reported this mostly just to do the right thing since I noticed. Other than that, the package was retired in Fedora, so that is not an issue anymore. But thx for fixing this.

  • 👍1