observing/pre-commit

Ignore version number bump commits

Closed this issue · 5 comments

For example, when running npm version patch or doing a bower version update which makes a commit and tag.

Why would you want to ignore those commits? I would say it's especially important to run the hooks at that moment to ensure that you're not releasing a broken build?

Fair enough. It was just a thought based on the duration some tests take and the fact that this commit shouldn't be changing anything that needs testing.

You can always skip these commits using the -n flag.

I see that npm also included support for git signing, so they might also be willing to add support for hook skipping: https://github.com/npm/npm/blob/master/lib/version.js#L148-L162

I think it would make more sense to solve this in npm & bower instead of this pre-commit module.

Perfect, thank you! 😄