Don't work when .git placed in parent directory

Question

Don't work when .git placed in parent directory

Opened this issue 9 years ago · 23 comments

Hi! Thanks for amazing solution of hooks implementation for node.js. But could you add support for cases when .git placed in parent directory relative to package.json?

villelahdenvuo commented 9 years ago

👍

davidchase commented 9 years ago

👍

metaman commented 9 years ago

👍

katmai7 commented 9 years ago

+1

trevordmiller commented 9 years ago

+1

medeeiros commented 9 years ago

👍

JakeCooper commented 8 years ago

+1!

Alex-Sokolov commented 7 years ago

👍

Answer 1 · 2015-05-07T07:18:02.000Z

@Swaagie Any thoughts on this? I'm neutral about it.

Answer 2 · 2015-05-25T13:35:51.000Z

👍 I have different parts of the project in separate directories within a single repo, this will solve the issue.

Answer 3 · 2015-05-26T09:54:57.000Z

I guess we could make this functionality opt-in by specifying the max depth that we can search for a .git folder.

Answer 4 · 2015-05-26T10:29:20.000Z

The only complication I can see, if I have multiple projects in a repository in subfolders that use pre-commit.

Answer 5 · 2015-07-31T09:27:28.000Z

@tuhoojabotti That's why I'm suggesting opt-in through a field in the package.json

Answer 6 · 2015-07-31T11:52:07.000Z

Yeah, I don't see an issue with that, but would it be possible to run the pre-commit hooks of all packages in sub folders? For example if I have a package.json file for both my back-end and front-end I would like to run both pre-commit hooks before allowing commit.

Answer 7 · 2015-10-21T16:21:27.000Z

Happy to give it a shot and create a PR. Could I get a hint please which part of the code to start with?

EDIT: not going to do that, was easier to just change my directory structure 😜

Answer 8 · 2015-10-22T07:51:59.000Z

@kosmotaur Probably the installation script of this module: https://github.com/observing/pre-commit/blob/master/install.js#L23-L28 as it checks if the parent folder has .git

Answer 9 · 2015-11-01T16:53:51.000Z

Btw, when using git submodules there will be a text file named .git in the same folder that will have a relative path inside to where the submodule real .git folder is.

Maybe this should be checked as well

Answer 10 · 2016-02-09T08:28:31.000Z

Hello, we suffer from the same issue here, and I would like to know if there is some kind of improvement to come (like the opt-in suggested by @3rd-Eden) ?

Answer 11 · 2016-02-23T19:57:54.000Z

This would be a great feature, especially for use with mono-repo projects like Lerna. Is there any plans to merge #55, or ways we can pitch in?

Answer 12 · 2016-06-22T14:30:09.000Z

+1 Has this been addressed somehow ?

Also, yes, to avoid any cross-OS issues a simple solution I guess would be to put a file calle .git-repo or something at the root where the node_modules folder is which would point to the root of the .git repo and simply fail if not found...

Answer 13 · 2016-08-24T19:21:13.000Z

We need this fix in my project with lint-staged.

I think it is very important for big projects with monorepo, when you have client/ and server/ subdirs.

@3rd-Eden how I can help with this issue?

Answer 14 · 2016-10-07T14:28:32.000Z

This project sets up hooks which will work when .git is in a parent directory

Answer 15 · 2017-11-30T16:50:47.000Z

I have a .git that's in a parent directory and it seems it's not detected by pre-commit which siletely fails when I installed it.

I tried creating a fake .git/hooks directory in the child directory where I run the npm installation and it works then.

Reading the comments I thought this was fixed?