observing/pre-commit

Support for use with sub-modules

Opened this issue · 5 comments

It would be really handy if pre-commit would also run scripts when repositories were used as submodules

http://stackoverflow.com/questions/10848191/git-submodule-commit-hooks

`git rev-parse --git-dir`/hooks

I have no idea how difficult this would be to implement.

Would be nice, but I don't know if should be default functionality. It might make sense to opt-in for in some way. Accepting pull requests for this as it's not really functionality that I would personally use.

I am stuck with a couple of sub-modules for awhile. I'll update this ticket, if I start working on it a PR.

What do you mean by submodules ?
Being able to npm test at the root and run others npm test in submodules ?

If so, i'm really interest and if someone implemented it, please let me know.

Any update on this?

I have found that when I include a git repository as a submodule of a another repository, that the hooks don't fire.

I have found that if I have a 'parent' repository A, and I include a submodule that is repository B then.

B does not have a folder .git
A has a folder .git/modules/B/ which looks like B's .git folder