Update logo for nervos app
Closed this issue · 11 comments
Hi there,
Since Nervos has updated its suite of logos, including the CKB symbol logo, we will need to update the logo of the ledger as well. The attached zip file contains the updated logos.
I had a try to update the icons in this folder and install the update app following the instruction on ubuntu 20.04.1, but the build/install command ./nix/install.sh -t s is not able to go beyond as the screenshot shown below:
Without being able to verify it on my own device, I am not sure if simply replacing the icons in the folder works. Would you please help take a look at this and update the new logo onto Ledger?
@katat are you working from a branch that we can look at?
Here is a PR to update the icons #204
But I haven't been able to verify if it works. Appreciated if you can help take a look.
Thanks
@katat our QA team was able to load the app from that commit (pulling from your repo actually). It loaded on the device and I'm including a paste of the output. Unfortunately the logo did not come across the way I guessing you would like. I've noticed that the nano-s-logo.gif changed from 16x16 pixels to 14x14 pixels. It's possible this is the cause.
For context, the Nano X logo is showing correctly. That one should remain unchanged.
Thanks @ApolloUnicorn
I have updated the icon of nano s to 16px and the PR to target the develop branch.
@katat I can't push commits because of repo access. Could you please add this logo as the nano-s-nervos.gif? When I looked at the pixel level preview of your last commit it showed gradients which the app cannot process.
Documenting the before and after of my logo changes
Before
After
Awesome @ApolloUnicorn
I have included this gif file you shared and pushed a new commit to the PR.
Thanks @ApolloUnicorn