send-prevents-chat-reports-to-client not working
Brottweiler opened this issue · 7 comments
Does send-prevents-chat-reports-to-client still work? In 1.20.6 and 1.21 my experience is that the icon does not show up in the server list. It shows up on a 1.20.4 server however.
In theory it's still supported as we re-write this packet to include the preventsChatReports field for mods that accept that. Unless that isn't working, or something else changed here. I will admit I am not really familiar with this, so it has not really been tested thoroughly, and it's entirely possible it could be broken, though no one has complained yet about it until now.
It would help me out if you can explain what you are doing to see this icon in the server list, and how it differs between older versions and the current version.
I am running No Chat Reports Fabric-1.21-v2.8.0 on the client and FreedomChat on the server. I run the latest version for 1.20.4, 1.20.6 and 1.21 respectively (1.21 version I took from GitHub actions). The icon in the server list shows up only for the 1.20.4 server (and all previous versions in the past), but since 1.20.6 the icon will not show up in the server list.
I am using 1.21 on the client, with ViaFabricPlus, which makes me able to join the 1.20.4 server. But the 1.20.4 server also runs ViaVersion so I can join with 1.21 even without ViaFabricPlus, but the point is that the icon still shows up for the 1.20.4 server just fine.
I hope that helps. I'm thinking no one else reported it because the option is off by default and maybe not used by many.
Yeah I don't think it's used by many people. I did specifically update this to maintain the feature when we updated to 1.20.6 though, so if it broke, that'd be when. I'll take a look when I get a chance (or if anyone else would like to before I end getting around to this, feel free).
Yep, facing this too. Please lmk when this is fixed!
@Brottweiler @CompeyDev Please check and confirm that this works for you in the latest build - should be fixed now thanks to @whiler-sesame finding the issue here.
Can confirm - it works!
All good now. Thanks!