ocpsoft/prettytime

PrettyTimeConverter: missing annotation

flange-ipb opened this issue · 3 comments

Hi folks!

Just a tiny issue: You can annotate the PrettyTimeConverter class with @FacesConverter("prettyTimeConverter"). Without this, the example on the web page does not work.

Thanks,
Frank

Hey Frank!

Thanks for pointing this out.
Could you give more details of where you're seeing or not seeing this info? Would love to fix it but need some more context.

Appreciated,
Lincoln

The converter should be registered by the bundled faces-config.xml

UP !
Additionaly PrettyTimeConverter does not support Java 8 JDK DateTime API

Hey @flange-ipb and @tomekkup - Thanks for the issue. Please send a test case that reproduces the issue and feel free to submit a PR/fix.