[FEATURE REQUEST] Ellipse method for canvas API
FayCarsons opened this issue · 3 comments
Hi! I am currently designing a creative coding library for OCaml, and I'd like it to be able to target the browser via the HTML canvas API. I've got a prototype working but I've hit a bit of a wall with rendering ellipses specifically: the ellipse method of the rendering context is missing. I would be happy to do the work to add it myself, but would probably need some guidance.
You need to add the missing method to canvasRenderingContext2D in
js_of_ocaml/lib/js_of_ocaml/dom_html.ml
Line 1753 in 0965d78
You should be able to copy and adjust signature found in other methods.
Don't forget to edit the mli file as well (dom_html.mli)
@hhugo Filed a PR! Do I need to add this to the Changelog in my branch? I noticed the CI failed because I hadn't.
I've merged your PR, Thanks for the contribution.