[BUG] Regression with `5.6.0`

Question

[BUG] Regression with `5.6.0`

toots opened this issue 10 months ago · 8 comments

Sorry, I don't have a minimal reproduction setup but the js build of the liquidsoap parser has a regression with js_of_ocaml 5.6.0:

Error while processing file ../liquidsoap/tests/language/eval.liq: Error: Unknown position:

Error -1: Exception raised: TypeError: sedlex_state_15 is not a function

The same build works with 5.5.2..

Answer 1 · 2024-01-30T12:24:38.000Z

Can you try with master ?

Answer 2 · 2024-01-30T12:25:04.000Z

Also, can you provide the problematic JS file ?

Answer 3 · 2024-01-30T16:29:05.000Z

It appears to be fixed if I install pinned version of this git repo's opam packages. This is a bit confusing, though, because the version is still reported as 5.5.2..

Answer 4 · 2024-02-02T10:40:42.000Z

I wonder if this is the same issue as #1559 ? can you provide the problematic js file ?

Answer 5 · 2024-02-06T12:15:31.000Z

@toots, gentle ping ..

Answer 6 · 2024-02-06T16:57:06.000Z

Yes! It's here: https://www.dropbox.com/s/r72ued5rv0fd5a9/interactive_js.bc.js?dl=0

Answer 7 · 2024-02-08T10:25:50.000Z

Thanks, the issue is different from #1559.

Regression introduced by #1544
Fixed by #1541

Thanks for the report. I'll try to make a new release soon

Answer 8 · 2024-02-10T07:44:14.000Z

It appears to be fixed if I install pinned version of this git repo's opam packages. This is a bit confusing, though, because the version is still reported as 5.5.2..

I've just tried installing version 5.5.2 followed by a opam pin add js_of_ocaml-compiler --dev and I see js_of_ocaml --version report version correctly.

$ js_of_ocaml --version
5.6.0+git-5.6.0-30-gb7d29593db-dirty

opam show js_of_ocaml-compiler still reports 5.5.2 though. Is this the behavior you've witness ? or is it js_of_ocaml --version that was incorrect ?