octokit/webhooks.net

workflow_job action ontology bugs

nwf opened this issue · 0 comments

nwf commented

The official documentation for workflow_job events gives the possible values of action as {queued, in_progress, completed}.

That means that

and the entirety of https://github.com/octokit/webhooks.net/blob/d1110bce90a2b9deaeb036eb5b12ca0e5e580fd3/src/Octokit.Webhooks/Events/WorkflowJob/WorkflowJobStartedEvent.cs

will never be used. The test suite file https://github.com/octokit/webhooks.net/blob/95e10f99238339f5ae712e73b5f4279debef7646/test/Octokit.Webhooks.Test/Resources/workflow_job/started.with-organization.payload.json is also stale.

At the same time, there should be code for queued and in_progress states added.