Change all applicable IDs from int to long
JamieMagee opened this issue · 4 comments
I suspect you've raised this now for the same reason I have suddenly found it important, but just to document, for posterity if nothing else: webhook_job ids are expressed in the JSON as numbers, and they're well and truly above 2**32. :(
Anytime an issue webhook event has a label, the id of the label is exceeds the size of an int and the json deserialization fails.
Obviously this applies to more than just the Label.Id but I'm adding a comment to get some additional attention on this. It's an absolute deal breaker for this SDK.
@moodymatt you're right. I haven't had much time recently to dedicate to maintenance here, but I opened a quick PR at #38.
@moodymatt you're right. I haven't had much time recently to dedicate to maintenance here, but I opened a quick PR at #38.
@JamieMagee awesome work and thanks for the quick response! I'll keep an eye out for the PR completing and update my references to the latest version of the SDK once all the checks have passed and its been merged down.