oddsdk/odd-app-template

Upgrade to SvelteKit stable release

Closed this issue · 3 comments

bgins commented

Summary

Problem

SvelteKit has released a 1.0.0, and we aren't using it.

Impact

No immediate impact, but moving to stable brings us forward past breaking changes.

Solution

Upgrade to latest SvelteKit stable release.

bgins commented

Let's hold off on making these changes until we've merged in #89.

bgins commented

We've rolled back this upgrade but should revisit it. We uncovered a couple of issues at page load.

In Safari:

SyntaxError: Invalid character '\u20ac'
parseModule
(anonymous function)
asyncFunctionResume
(anonymous function)
promiseReactionJobWithoutPromise
promiseReactionJob

In Chrome:

chrome-error

We suspect Vite 4 is having issues processing special characters.

bgins commented

Turned out the first error was due to a missing meta utf-8 tag. The tag was not compiled in statically by SvelteKit. Fixed by adding the tag directly to app.html.

The second error is unrelated. Tracking that one here: oddsdk/ts-odd#459