oddsdk/odd-app-template

Private file info rather than view on IPFS

Closed this issue · 5 comments

bmann commented

Remove the "view on IPFS" link for private files / photos.

Maybe an "I" for info button with a short note "private files can only be viewed on other devices. Follow private file sharing (link to GitHub issue here)"

avivash commented

@depatchedmode flagging this for the design team as there may be some specific design considerations we want to implement to show users that this is a feature/benefit of WNFS. Otherwise, i can implement a simple tooltip, as suggested in the issue description 👍🏼

depatchedmode commented

I'm actually tempted to leave the "view on IPFS" link in there, with a supporting explanation. I think it's more instructional in the sense that it provides evidence of the fact your data is encrypted. Because this sample Photos gallery in the WAT is meant to be a learning resource for developers, I think we should just be explicit and up front.

Something like this:
image

avivash commented

I'm actually tempted to leave the "view on IPFS" link in there, with a supporting explanation. I think it's more instructional in the sense that it provides evidence of the fact your data is encrypted. Because this sample Photos gallery in the WAT is meant to be a learning resource for developers, I think we should just be explicit and up front.

Something like this: image

Nice! I like that idea 👍🏼

avivash commented

This has been PRd against the two WAT repos. I'm working on a different spike for the rest of this week, but will implement this in the two WalletAuth repos ASAP 👍🏼

avivash commented

This has been implemented in the WalletAuth repos, as well