core:image which_bytes proc fails to detect .PIC format

[softmonkey]

Context

Locally I've added a backend for the Softimage PIC format that is listed in the core:image package. The current which_bytes proc in image/general.odin at line 196 has inverted logic in the first test for checking the header contents. It checks for != instead of == unlike other formats in this file.

• Operating System & Odin Version:
  Odin: dev-2024-10:9f609dd74
  OS: Windows 11 Enterprise (version: Dev), build ---redacted---
  CPU: AMD Ryzen Threadripper PRO 3955WX 16-Cores
  RAM: 130923 MiB
  Backend: LLVM 18.1.8

Expected Behavior

line 196 in master:
case s[:4] == "\x53\x80\xF6\x34" && s[88:92] == "PICT"
See diff in Failure Information below...

Current Behavior

Softimage PIC files aren't recognized correctly in which_bytes proc.

Failure Information (for bugs)

Here is the diff showing the fix.

diff --git a/core/image/general.odin b/core/image/general.odin
index 17a8f35ea..f3847e514 100644
--- a/core/image/general.odin
+++ b/core/image/general.odin
@@ -185,7 +185,7 @@ which_bytes :: proc(data: []byte) -> Which_File_Type {
                return .HDR
        case s[:4] == "\x38\x42\x50\x53":
                return .PSD
-       case s[:4] != "\x53\x80\xF6\x34" && s[88:92] == "PICT":
+       case s[:4] == "\x53\x80\xF6\x34" && s[88:92] == "PICT":
                return .PIC
        case s[:4] == "\x69\x63\x6e\x73":
                return .ICNS

Steps to Reproduce

I can provide PIC reader code + images if needed for verification/testing.

Failure Logs

[Kelimion]

I've found some example files here: https://sembiance.com/fileFormatSamples/image/softimage/

Will give it a look in the morning. Thanks for the report.