odoomates/odooapps

om_account_asset: Thoughts on converting float fields to monetary?

kwoychesko opened this issue · 3 comments

The asset module uses float fields for all currency fields and I'm wondering if we should change them to "monetary" fields?
Reasons:

  1. The current float fields are not rounded, and as a result the database stores values with many more decimal places than the company currency (see image below). Maybe this is okay & normal in the Odoo development world?
  2. A lot of work is done using float_compare and decimal precision, and I wonder if we made the fields monetary would some of this extra work go away?

Would love your thoughts.

Ken

image

Thanks for bring the attention and yes we can make it Monetary for better working of the system

It's funny: the fields are still stored in the database in the same way. Is Odoo's "Monetary" field type is mostly a display convenience?

image

I'll close this--fix looks great!