oe-alliance/OpenWebif

`OpenWeblnterface Enabled` should state *Requires restart

Opened this issue · 8 comments

wedebe commented

Enabling/disabling OpenWeblnterface has no effect until the box is restarted.

20230504125412

wedebe commented

Are you sure?

https://github.com/oe-alliance/OpenWebif/blob/main/plugin/plugin.py#L158-L161

Yep, setting OpenWeblnterface enabled to No takes no effect - pages are still served and functions such as Send Message still work.

wedebe commented

KEY_RIGHT to set No
KEY_GREEN to Save...

22:32:42.3606 [eRCDeviceInputDev] 1 6a 1
22:32:42.3611 [InfoBarGenerics] Key 'KEY_RIGHT' (106) Make.
22:32:42.3614 [ActionMap] Map context 'NavigationActions' -> Action 'right'.
22:32:42.3621 [Setup] XML cached setup file '/usr/lib/enigma2/python/Plugins/Extensions/OpenWebif/setup.xml', using element 'openwebif' from plugin 'Extensions/OpenWebif'.
22:32:42.5141 [eRCDeviceInputDev] 0 6a 1
22:32:42.5145 [InfoBarGenerics] Key 'KEY_RIGHT' (106) Break.
22:32:52.1671 [eRCDeviceInputDev] 1 18f 1
22:32:52.1675 [InfoBarGenerics] Key 'KEY_GREEN' (399) Make.
22:32:52.1678 [ActionMap] Map context 'ConfigListActions' -> Action 'save'.
22:32:52.1682 [OpenWebif] Stopping server on port:80
22:32:52.1813 [Screen] Showing screen 'PluginBrowserSummary'.
22:32:52.1826 (TCP Port 80 Closed)
22:32:52.1835 Stopping factory <twisted.web.server.Site object at 0xaf6a0d90>
22:32:52.1901 [Screen] Showing screen 'PluginBrowser'.
22:32:52.3222 [eRCDeviceInputDev] 0 18f 1
22:32:52.3227 [InfoBarGenerics] Key 'KEY_GREEN' (399) Break.
jbleyel commented

Looks similar to my log and on my box the port 80 is closed and the Website is no longer available.

wedebe commented

When box is booted with owif already disabled... -> enable -> disable

23:37:03.7790 [eRCDeviceInputDev] 1 6a 1
23:37:03.7796 [InfoBarGenerics] Key 'KEY_RIGHT' (106) Make.
23:37:03.7800 [ActionMap] Map context 'NavigationActions' -> Action 'right'.
23:37:03.7808 [Setup] XML cached setup file '/usr/lib/enigma2/python/Plugins/Extensions/OpenWebif/setup.xml', using element 'openwebif' from plugin 'Extensions/OpenWebif'.
23:37:03.9342 [eRCDeviceInputDev] 0 6a 1
23:37:03.9348 [InfoBarGenerics] Key 'KEY_RIGHT' (106) Break.
(enabled now at Yes)


23:37:09.6523 [eRCDeviceInputDev] 1 18f 1
23:37:09.6528 [InfoBarGenerics] Key 'KEY_GREEN' (399) Make.
23:37:09.6533 [ActionMap] Map context 'ConfigListActions' -> Action 'save'.
23:37:09.6626 [OpenWebif] loading external plugins...
23:37:09.6642 [OpenWebif] no plugins to load
23:37:09.6658 Site starting on 80
23:37:09.6668 Starting factory <twisted.web.server.Site object at 0xaece5ff0>
23:37:09.6673 [OpenWebif] started on 80
23:37:09.6682 [Avahi] AvahiServiceEntry (null) (_http._tcp) 80
23:37:09.6695 [Avahi] Will Register mutant51 (_http._tcp) on mutant51:80
23:37:09.6708 [Avahi] Registered mutant51 (_http._tcp) on mutant51:80
23:37:09.6852 [Screen] Showing screen 'PluginBrowserSummary'.
23:37:09.6911 [Screen] Showing screen 'PluginBrowser'.
23:37:09.8063 [eRCDeviceInputDev] 0 18f 1
23:37:09.8068 [InfoBarGenerics] Key 'KEY_GREEN' (399) Break.
23:37:10.6040 [Avahi] watch activated: 0x1
(saved)


23:37:20.3648 [eRCDeviceInputDev] 1 160 1
23:37:20.3654 [InfoBarGenerics] Key 'KEY_OK' (352) Make.
23:37:20.3659 [ActionMap] Map context 'WizardActions' -> Unknown action 'ok'!  (Typo in map?)
23:37:20.3660 [ActionMap] Map context 'SetupActions' -> Action 'ok'.
23:37:20.3694 [Setup] XML cached setup file '/usr/lib/enigma2/python/Plugins/Extensions/OpenWebif/setup.xml', using element 'openwebif' from plugin 'Extensions/OpenWebif'.
23:37:20.3869 [Setup] Default image '/usr/share/enigma2/MetrixHD/icons/setup.png'.
23:37:20.3885 [Skin] Warning: Skin screen 'OpenWebifConfig' rejected as it does not offer all the mandatory widgets 'config, footnote, description'!
23:37:20.3892 [Skin] Processing screen 'Setup' from list 'OpenWebifConfig, setup_openwebif, Setupopenwebif, Setup', position=(0, 0), size=(1280x720) for module 'OpenWebifConfig'.
23:37:20.4022 [Skin] Processing screen 'SetupSummary' from list 'OpenWebifConfigSummary, setup_openwebifSummary, SetupopenwebifSummary, SetupSummary, ScreenSummary, OpenWebifConfig_summary, setup_openwebif_summary, Setupopenwebif_summary, Setup_summary, SimpleSummary', position=(0, 0), size=(132x64) for module 'SetupSummary'.
23:37:20.4038 [Screen] Showing screen '['OpenWebifConfigSummary', 'setup_openwebifSummary', 'SetupopenwebifSummary', 'SetupSummary', 'ScreenSummary', 'OpenWebifConfig_summary', 'setup_openwebif_summary', 'Setupopenwebif_summary', 'Setup_summary', 'SimpleSummary']'.
23:37:20.4049 [Screen] Showing screen '['OpenWebifConfig', 'setup_openwebif', 'Setupopenwebif', 'Setup']'.
23:37:20.5183 [eRCDeviceInputDev] 0 160 1
23:37:20.5188 [InfoBarGenerics] Key 'KEY_OK' (352) Break.



23:37:24.8946 [eRCDeviceInputDev] 1 6a 1
23:37:24.8954 [InfoBarGenerics] Key 'KEY_RIGHT' (106) Make.
23:37:24.8960 [ActionMap] Map context 'NavigationActions' -> Action 'right'.
23:37:24.8968 [Setup] XML cached setup file '/usr/lib/enigma2/python/Plugins/Extensions/OpenWebif/setup.xml', using element 'openwebif' from plugin 'Extensions/OpenWebif'.
23:37:25.0462 [eRCDeviceInputDev] 0 6a 1
23:37:25.0467 [InfoBarGenerics] Key 'KEY_RIGHT' (106) Break.
(enabled now at No)


23:37:32.0085 [eRCDeviceInputDev] 1 18f 1
23:37:32.0091 [InfoBarGenerics] Key 'KEY_GREEN' (399) Make.
23:37:32.0095 [ActionMap] Map context 'ConfigListActions' -> Action 'save'.
23:37:32.0098 [OpenWebif] Stopping server on port:80
23:37:32.0239 [Screen] Showing screen 'PluginBrowserSummary'.
23:37:32.0254 (TCP Port 80 Closed)
23:37:32.0264 Stopping factory <twisted.web.server.Site object at 0xaece5ff0>
23:37:32.0325 [Screen] Showing screen 'PluginBrowser'.
23:37:32.1663 [eRCDeviceInputDev] 0 18f 1
23:37:32.1669 [InfoBarGenerics] Key 'KEY_GREEN' (399) Break.
(saved)
jbleyel commented

It look like the same log entries again after save.

“..stopping factory…” is twisted

I have no idea what todo if this is not working as expected on your box.
Because I cannot reproduce the issue.

wedebe commented

Would you know which files/lines I should add debug prints to? I wonder whether there's an exception being triggered and silently caught.