How to push a commit here?
Lexzie opened this issue · 7 comments
I made changes with Github Desktop yesterday and pushed them to the repository.
At least I thought I did (just like I do in other repositories).
But I don't see anything has changed here.
I changed the cables.xml I see you used my file from Sat4all, but it's not up-to-date here.
You can't push to this repo unless you are a member, but, you can make a pull request.
No changes to satellites.xml. Only to Terrestrial.xml and Cables.xml.
We did not use your file from Sat4all.
Edit: You submitted a pull request in Feb 2022.
All OE-A images and PLI use the name, not position on xml file. It has been like that for a number of years. We keep them in alphabetical order. You can ignore the don't split the file that others say.
Countries sorted by three letter country code (ISO 3166).
Regions sorted alphabetically.
We also use the space before closing bracket as some editors need them.
We did not use your file from
Sat4all.
I base that on the remark before the PR#107 of Feb 2022 :
<!-- Dutch cable providers. Based on the work of Alex1970 27-06-2017 -->
And I never submitted anything before 1-2-2022.
It's no problem, but don't say you never used my file.
All OE-A images and PLI use the name, not position on xml file. It has been like that for a number of years. We keep them in alphabetical order. You can ignore the
don't split the filethat others say.Countries sorted by three letter country code (ISO 3166). Regions sorted alphabetically.
I will make a Pull Request with this in mind.
We also use the space before closing bracket as some editors need them.
Then I will do that in my file too.
Is there a reason for using flags="9" ?
I understand that and why I can't push into this repository, but when making the changes I can do a push in Github Desktop to master branch.
I probably should have done it otherwise, but where did that push go??
Edit: I think I found it.
PR #118
You pushed to your fork/copy. You can submit pull request using the website.