unused dependencies in cpanfile?

Question

unused dependencies in cpanfile?

lelutin opened this issue 2 years ago · 5 comments

I'm currently reviewing dependencies for the debian package of smokeping as I'm preparing to send version 2.8.2.

I saw two lines in the cpanfile at the top of this repository for which I could not find any reference/inclusion in the codebase, so I'm wondering if they are still necessary or if they can be taken out:

JSON::MaybeXS
Object::Result

Cheers!

Answer 1 · 2022-05-02T06:56:01.000Z

Yes, please :) if things break, the tests should show

Answer 2 · 2022-05-03T13:16:30.000Z

digging into the commit history, I can see that both of the lines were added in d38a064 for InfluxDB. so maybe this issue is actually not relevant?

Answer 3 · 2022-05-03T13:20:37.000Z

Indeed: https://metacpan.org/release/RAPHI/InfluxDB-HTTP-0.04/source/lib/InfluxDB/HTTP.pm and they are not listed as dependencies in Makefile.PL ... yey

Answer 4 · 2022-05-03T13:20:56.000Z

you could add a comment to the cpanfile :)

Answer 5 · 2022-05-03T13:22:55.000Z

oh wow good find. I had checked dependencies on metacpan.org and was a bit puzzled there.

ok good, I'll add a comment in the cpanfile then so we'll remember about this. and it sounds like maybe a bug report on that lib is in order too..