oetiker/SmokePing

Fix for bug #90 was incomplete

dadv opened this issue · 4 comments

dadv commented

Hi!

The bug #90 was fixed 5 years ago for FPing.pm with commit:
72ed157

Same bug is still present in FPingContinuous.pm and same change solves same problem there. Please fix FPingContinuous.pm, too.

dadv commented

As side note: modern curl binary does not print all needed info if called just as "curl --help", so Curl.pm and AnotherCurl.pm fail to detect "-m" and "--interface" options support even if it is present. Modern curl prints it all only if called as "curl --help all".

As side note: modern curl binary does not print all needed info if called just as "curl --help", so Curl.pm and AnotherCurl.pm fail to detect "-m" and "--interface" options support even if it is present. Modern curl prints it all only if called as "curl --help all".

Please open a separate issue for Curl/AnotherCurl.pm.

Hi!

The bug #90 was fixed 5 years ago for FPing.pm with commit: 72ed157

Same bug is still present in FPingContinuous.pm and same change solves same problem there. Please fix FPingContinuous.pm, too.

Please test with https://github.com/Strykar/SmokePing/blob/master/lib/Smokeping/probes/FPingContinuous.pm and let us know if it works.

dadv commented

It works, thanks.