fping help output changed/FPingContinuous does not detect feature
NBD-Chris opened this issue · 3 comments
FPingContinuous.pm expects the help output of the fping command to match the pattern "\s-S\s". The actual help output is now "-S, --src=IP set source address", so the FPingContinuous module believes that it's not possible to set the source address.
I just changed the pattern to "\s-S[\s,]".
Same problem with the -O option to set the type of service (tos) flag on the ICMP packets. Same sort of fix.
The FPing.pm module already has this fix.
Hi @NBD-Chris, thank you for your patch. If you directly edit: https://github.com/oetiker/SmokePing/edit/master/lib/Smokeping/probes/FPingContinuous.pm you would even get credit for the fix :) how about it ?
This issue has become stale and will be closed automatically within 7 days. Comment on the issue to keep it alive.