cropper broken, smokeping.js TypeError: window.options is undefined
FliesLikeABrick opened this issue · 2 comments
We are running 2.8.2+ from latest git master.
Original issue we were investigating was that the cropper was no longer working.
We saw in network tools in-browser that the expected JS resources were all being downloaded, but an error was in the JS console from smokeping.js line 127 "TypeError: window.options is undefined"
It appears the latest commit to smokeping.js from January 2023 was adding some auto-refresh capability. "window.options.step" is being accessed which does not appear to be valid in latest Firefox (and I believe our teammates reported the same issue with Chrome and Edge)
}, window.options.step * 1000);
We reverted to the prior commit of smokeping.js which resolved the issue; we are not sure what functionality is lost as a result
I am not sure the intent of that "window.options.step" reference to propose a fix at this time.
@oetiker care to give this a look? I think the fix here is fairly simple but I don't know the context of how the issue was introduced to offer it in a PR
probably your base page is missing the script section ... see here: