Wrong comparison of strings
Opened this issue · 3 comments
kuramayoko10 commented
the method videoInput::getDeviceIDFromName(char * name)
is implemented incorrectly. It is comparing two pointers (char*) instead of strings.
Is order to solve this, simply use the c function strcmp(char*,char*)
like so:
int videoInput::getDeviceIDFromName(char * name) {
if (listDevices(true) == 0) return -1;
int deviceID = -1;
for (int i = 0; i < VI_MAX_CAMERAS; i++) {
if (strcmp(deviceNames[i], name) == 0) {
deviceID = i;
break;
}
}
return deviceID;
}
ofTheo commented
Hi apologies!
Trying to get back on top of VI stuff
If you would like to submit a PR I will merge it in.
All the best!
Theo
MIvanchev commented
Sure thing, I'll hit you up with a PR =)