ofTheo/videoInput

Wrong comparison of strings

Opened this issue · 3 comments

the method videoInput::getDeviceIDFromName(char * name) is implemented incorrectly. It is comparing two pointers (char*) instead of strings.

Is order to solve this, simply use the c function strcmp(char*,char*) like so:

int videoInput::getDeviceIDFromName(char * name) {
    if (listDevices(true) == 0) return -1;
    int deviceID = -1;
    for (int i = 0; i < VI_MAX_CAMERAS; i++) {
        if (strcmp(deviceNames[i], name) == 0) {
            deviceID = i;
            break;
        }
    }
    return deviceID;
}

This issue is a clone of #20.

Sure thing, I'll hit you up with a PR =)