ofekp/TinyUPnP

Check IP when verifying the port mappings are in the IGD

ofekp opened this issue · 2 comments

ofekp commented

If the device changes its IP address it will still recognize the rules in the IGD as valid since the IP address is not checked.
The device should verify that the port mapping in the IGD is directing to the correct (current) IP address of the device.
Also, adding the rule to the IGD after the IP was changed (and the device did not restart) causes the old IP to be added to the rule instead of the new IP.
Should verify that the current IP will be updated before adding a rule. The port can be updated in the device's memory when it is detected that it changed when verifying the rules in the IGD.

ofekp commented

Started:
#27

Still need to verify by assigning a static address or removing the device DHCP lease while the device is up.

ofekp commented

Resolved.