offen/docker-volume-backup

Documentation issues with custom commands

nigelm opened this issue · 1 comments

nigelm commented

Describe the bug

Documentation issues with custom commands:-

  1. The docker socket must be mounted for custom commands to work (needs to see labels) - the socket is not just for stopping containers.
  2. The docker-compose labels are seen across the whole docker estate, so unless you use unique EXEC_LABELs, should you have multiple docker-volume-backup sets, you will end up running all the custom commands across the estate even those within entirely different docker-compose configurations
m90 commented

Thanks for raising these points. Would you mind opening a PR that rectifies these things in places where you found them to be misleading?