run not assigned workers
Closed this issue · 4 comments
https://tests.stockfishchess.org/tests/view/6664d56b22234461cef58e73 is no longer assigned workers (even if prio 1).
Probably this is fallout from #2049
The particular thing for this run, it had auto-purge enabled, and one worker was purged. Maybe accounting of the number of games played is not taking this correctly into account
also a stop and a later modify (restart) doesn't seem to help
https://tests.stockfishchess.org/tests/view/6664d56b22234461cef58e73 is no longer assigned workers (even if prio 1).
Probably this is fallout from #2049
It seems so. Purging did not update the list of committed games correctly according to https://tests.stockfishchess.org/api/get_run/6664d56b22234461cef58e73 (it is still at 60000).
Restarting the server should fix it. I will try to find the bug.
EDIT: I already found it. "set_inactive_task()" (which updates the number of committed games) does nothing for a task that is already inactive (as is the case with a purged run").
Probably creating a "set_bad_task()" is the best solution.
Meanwhile Fishtest came to the same conclusion https://tests.stockfishchess.org/actions?max_actions=1&action=&user=&text=&before=1718006496.12471&run_id=