oflisback/react-favicon

Upgrade peerDependencies

Closed this issue · 4 comments

Redirts commented

"peerDependencies": {
"react": "^16.0.0 || ^17.0.0"
}

version 17.0.2 of React is out already. Maybe you can change the semver check to 17.0?

Thanks

oflisback commented

I think we're fine with that peerDependencies value, you can validate semver strings here:

https://jubianchi.github.io/semver-check/#/%20^16.0.0%20||%20^17.0.0/17.0.2

Redirts commented

Strange because I am getting this warning on npm install:

npm WARN react-favicon@0.0.18 requires a peer of react@>=0.12.0 <17.0.0 but none is installed. You must install peer dependencies yourself.

I have react 17.0.1

Redirts commented

Ah! Mystery solved :-) I didn't notice it had changed. I will upgrade then and close this ticket. Thanks

  • 👍1