ofpiyush/dokuwiki-extension-manager

code design

Opened this issue · 0 comments

I'm not too fond of how an instance of the admin or action plugin is passed to the various manager classes which then work on some member variables of this passed instance.

It makes it very hard to follow the code flow. IMHO the main plugin classes should never be passed around and modified. Instead they should simply use the manager classes to create the wanted output (or get certain return values).