oguzhanogreden/dcurver

Description and limitation of bounds

Closed this issue · 0 comments

#' A maximum of 10 parameters is allowed, all of which should be between -90 < phi <= 90.

Lines like this should be patched both in the documentation and in the code (such as here). There really is no theoretical limitation regarding the input values given the operations defiend. So long as sin(phi) and cos(phi) supply reasonable values, which they do across the real number line, then no such bound problem will exist. That isn't to say that these results are useful due to the cyclical phi + 2pi nature to them, but nonetheless I found these descriptions a bit odd, and may confuse others who look into the detail of this package.