mapMaker Add Row button doesn't work

Question

mapMaker Add Row button doesn't work

Closed this issue 5 years ago · 7 comments

ohiofi commented 5 years ago

I was able to get the Add Column button to work, but the Add Row button doesn't seem to do anything?

not-arzuaga commented 5 years ago

check #22

👍1

Answer 1 · 2019-10-31T19:29:58.000Z

I will also look into this

Answer 2 · 2019-10-31T19:32:42.000Z

@hmuhammadazeem he is saying that when in mapmaker.html pressing add row doesnt do anything

Answer 3 · 2019-10-31T19:50:15.000Z

I think the issue is that when you create a new row, it doesnt append to the map so when let pixelElement = map[row][col] it breaks due to that

Answer 4 · 2019-10-31T20:04:35.000Z

The other issue is to change the map accordingly, because if you make a change and then you do add column/row the map resets, but this allows to add rows

Answer 5 · 2019-10-31T20:08:10.000Z

I fixed the adding of the row is working as the issue intended with #22 , the changing of the map accordingly should be another issue, I think. But I think I could also work on that

Answer 6 · 2019-10-31T22:46:24.000Z

Thanks. I’ll close this issue then. I should’ve known that it was just an “index out of range” issue, but it was throwing a weird error message that confused me.