ojacques/mkdocs-git-committers-plugin-2

Image quality is bad (too small)

squidfunk opened this issue · 3 comments

squidfunk commented

Thanks for maintaining this fork! As you may have noticed, insiders-4.19.0 adds native support for this nice little plugin. However, I've noticed, that images are rendered too small, due to this line:

mkdocs-git-committers-plugin-2/mkdocs_git_committers_plugin_2/plugin.py

Line 70 in af146bb

'avatar':info['url']+".png?size=24" }

Could we remove the size parameter? IMHO, it's better left to the template/theme author which size is needed to display the avatar, because the size of the image heavily depends on CSS. For example, we need size=72.

ojacques commented

Agreed that 24 can be small. Makes sense to remove the size in the avatar attribute.

  • 🚀1
ojacques commented

Fix coming in 0.4.2. @squidfunk - you will have to update mkdocs-material to use &size=72 instead of ?size=72.
Nice workaround that you used though!

  • ❤️1