Build error against PostgreSQL 9.6

[devrimgunduz]

Hi Pavel,

pgimportdoc fails to build against PostgreSQL 9.6, on all RPM platforms that we support:

+ /usr/bin/make -j3
pgimportdoc.c: In function 'pgimportdoc':
pgimportdoc.c:84:3: warning: passing argument 2 of 'simple_prompt' makes integer from pointer without a cast [enabled by default]
   simple_prompt("Password: ", password, sizeof(password), false);
   ^
In file included from /usr/pgsql-9.6/include/server/c.h:1105:0,
                 from /usr/pgsql-9.6/include/server/postgres_fe.h:25,
                 from pgimportdoc.c:13:
/usr/pgsql-9.6/include/server/port.h:206:14: note: expected 'int' but argument is of type 'char *'
 extern char *simple_prompt(const char *prompt, int maxlen, bool echo);
              ^
pgimportdoc.c:84:3: error: too many arguments to function 'simple_prompt'
   simple_prompt("Password: ", password, sizeof(password), false);
   ^
In file included from /usr/pgsql-9.6/include/server/c.h:1105:0,
                 from /usr/pgsql-9.6/include/server/postgres_fe.h:25,
                 from pgimportdoc.c:13:
/usr/pgsql-9.6/include/server/port.h:206:14: note: declared here
 extern char *simple_prompt(const char *prompt, int maxlen, bool echo);
              ^
pgimportdoc.c:130:4: warning: passing argument 2 of 'simple_prompt' makes integer from pointer without a cast [enabled by default]
    simple_prompt("Password: ", password, sizeof(password), false);
    ^
In file included from /usr/pgsql-9.6/include/server/c.h:1105:0,
                 from /usr/pgsql-9.6/include/server/postgres_fe.h:25,
                 from pgimportdoc.c:13:
/usr/pgsql-9.6/include/server/port.h:206:14: note: expected 'int' but argument is of type 'char *'
 extern char *simple_prompt(const char *prompt, int maxlen, bool echo);
              ^
pgimportdoc.c:130:4: error: too many arguments to function 'simple_prompt'
    simple_prompt("Password: ", password, sizeof(password), false);
    ^
In file included from /usr/pgsql-9.6/include/server/c.h:1105:0,
                 from /usr/pgsql-9.6/include/server/postgres_fe.h:25,
                 from pgimportdoc.c:13:
/usr/pgsql-9.6/include/server/port.h:206:14: note: declared here
 extern char *simple_prompt(const char *prompt, int maxlen, bool echo);
              ^
In file included from pgimportdoc.c:24:0:
/usr/pgsql-9.6/include/internal/pqexpbuffer.h:60:9: warning: the comparison will always evaluate as 'false' for the address of 'data' will never be NULL [-Waddress]
  ((str) == NULL || (str)->maxlen == 0)
         ^
pgimportdoc.c:243:11: note: in expansion of macro 'PQExpBufferBroken'
  else if (PQExpBufferBroken(&data))
           ^
make[1]: *** [pgimportdoc.o] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.6t0e9g (%build)
    Bad exit status from /var/tmp/rpm-tmp.6t0e9g (%build)

Can you please take a look?

Thanks!
Devrim

[okbob]

7ae5a26