okbob/pspg

SIGSEGV if expanded display is on

mjf opened this issue · 4 comments

mjf commented

Version:

$ pspg -V
pspg-5.3.4
with readline (version: 0x0700)
with integrated menu
ncurses version: 6.1, patch: 20180224
ncurses with wide char support
ncurses widechar num: 1
wchar_t width: 4, max: 2147483647
with postgres client integration
with inotify support

How to crash:

$ psql
$ \x
Expanded display is on.
$ SELECT 1;
pspg crashed by signal 11

My psql(1) config:

$ cat .psqlrc 
\encoding

\pset border 2
\pset footer on
\pset null 'NULL'
\pset pager always

\set COMP_KEYWORD_CASE upper
\set ECHO_HIDDEN ON
\set HISTCONTROL ignoredups
\set HISTFILE ~/.psql_history_ :DBNAME _ :USER
\set HISTSIZE 10000
\set IGNOREEOF 0
\set PROMPT1 'postgresql://%n@%M:%>/%/\n%# '
\set PROMPT2 '%R> '
\set SHOW_CONTEXT errors
\set VERBOSITY terse

\setenv PAGER 'pspg'

\timing on
okbob commented

I cannot to reproduce crash on my fedora o.s, but I see some visual defects. Please, can you send the backtrace?

okbob commented

I fixed detection of extended mode, that was possible broken for one row results. Please, check.

mjf commented

[...] that was possible broken for one row results

@okbob Exactly. It indeed happened exclusively for single row results.

okbob commented

please, can you check 5.3.5 release?