could not build codemirror 6 correctly

Question

could not build codemirror 6 correctly

emergence75 opened this issue 2 years ago · 10 comments

emergence75 commented 2 years ago

just tried the tool on https://bundlejs.com/

with option set
"format": "iife",
"minify": false,

using this logic descriped here to build a codemirror 6
https://codemirror.net/examples/bundle/

import {EditorView, basicSetup} from "codemirror"
import {javascript} from "@codemirror/lang-javascript"

let editor = new EditorView({
extensions: [basicSetup, javascript()],
parent: document.body
})

when building the console brings me
Bundling 🚀

Done ✨

the problem with this is, that multiple versions e.g state or view are also included and the generated codemirror js does not work...
testing the generated code brings
Uncaught Error: Unrecognized extension value in extension set ([object Object]). This sometimes happens because multiple instances of @codemirror/state are loaded, breaking instanceof checks.

by the way, cool project...

Answer 1 · 2023-02-15T17:15:40.000Z

I'll look into this, thanks for creating an issue

Answer 2 · 2023-02-16T16:37:41.000Z

@emergence75 Please take a look. I've pushed a possible fix out, did this fix the issue you were having?

Answer 3 · 2023-02-17T06:18:25.000Z

just testet...

https://bundlejs.com/?q=%28import%29codemirror%2C%28import%29%40codemirror%2Flang-javascript&treeshake=%5B%7BEditorView%2CbasicSetup%7D%5D%2C%5B%7Bjavascript%7D%5D&text=%22let+editor+%3D+new+EditorView%28%7B%5Cnextensions%3A+%5BbasicSetup%2C+javascript%28%29%5D%2C%5Cnparent%3A+document.body%5Cn%7D%29%22&config=%7B%22esbuild%22%3A%7B%22format%22%3A%22iife%22%2C%22minify%22%3Afalse%7D%7D

same problem...

Initialized 🚀✨

Bundling 🚀

Fetch https://unpkg.com/crelt@%5E1.0.5

Done ✨

Answer 4 · 2023-02-17T06:20:03.000Z

Ok, I'll do some more research on this

Answer 5 · 2023-03-06T06:52:34.000Z

This should provide context on what I think the error is here #43 (comment)

Answer 6 · 2023-03-06T07:23:26.000Z

I now have a fix, I'll try to get it out by tmrw

Answer 7 · 2023-03-06T15:14:33.000Z

@emergence75 Take a look https://stackblitz.com/edit/vitejs-vite-iquaht?file=src%2Fmain.ts&terminal=dev

Answer 8 · 2023-03-06T21:11:56.000Z

very cool ;-)

Answer 9 · 2023-03-06T21:16:32.000Z

I've not yet added the fix to the bundlejs.com website but as you can see it's now fixed and the fix should be published soon

Answer 10 · 2023-05-12T19:49:59.000Z

I forgot to update this issue, I already added support for this on the bundlejs website, so this should be fixed everywhere now