okkur/syna

Incorrect use of `ne` comparison breaks with hugo v0.92.2

abrain opened this issue · 1 comments

abrain commented

Is this a BUG REPORT or FEATURE REQUEST?:
bug

What happened:

After updating hugo to the newest version, executing hugo server -D caused the following error:

ERROR 2022/02/14 20:12:17 render of "page" failed: execute of template failed: template: _default/single.html:5:6: executing "main" at <partial "helpers/fragments.html" (dict "page_scratch" $.Scratch)>: error calling partial: "[REDACTED]/themes/syna/layouts/partials/helpers/fragments.html:184:115": execute of template failed: template: partials/helpers/fragments.html:184:115: executing "partials/helpers/fragments.html" at <ne .Params.hide>: error calling ne: missing arguments for comparison

What you expected to happen:
No errors, as before the hugo update.

How to reproduce it (as minimally and precisely as possible):
Check out the Syna starter repo and serve it with hugo v0.92.2:

git clone --recurse-submodules https://git.okkur.org/syna-start
cd syna-start 
hugo server -D

Anything else we need to know?:
This seems to be caused by gohugoio/hugo#9462. The change was released just a few days ago.

Changing (ne .Params.hide) to (not .Params.hide) in fragments.html:184 worked as a quick fix.

Environment:

  • Syna Theme version: v0.17.4
  • Hugo version: v0.92.2+extended darwin/amd64
  • Others:
stp-ip commented

Great catch. If you wanna submit a PR, that would be awesome.