okkur/syna

Portfolio fragment broken with hugo versions later than 0.80.0

mrhappyma opened this issue · 8 comments

Hello!

I have a bit of an interesting scenario I was unable to figure out. I was making a site using the syna theme and added a portfolio fragment. I committed the changes to a new branch, and had Netlify make a preview:
https://6320e78fce2f740008728766--lt-monsters.netlify.app/
So far so good, everything was working. I merged it into the main branch, no other changes:
https://6320e7f5ba71700008b9d0df--lt-monsters.netlify.app/
The pop-ups don't work anymore. I can't think of anything that would make a difference.

ha - found the problem just after creating an issue about it

I had upgraded the hugo version in netlify.toml, but only for production environments. This fragment seems to break with more recent versions.

Seems like 0.80.0 is the highest version that this works with
mrhappyma/lt#3

Disable minification as this is the thing that seems to break since a specific hugo version. Dup #865

Just for information, this is still broken with Hugo v102.3 extended and with:

[minify]
disableJS = true

Even with minification disabled this is the case? Thank you for clarifying.

Items fragment is also broken, issue is the same as with portfolio.

Looks like the issue stems from https://github.com/okkur/syna/blob/master/layouts/partials/helpers/subitems.html

Could be an issue similar to what was solved by @abrain in #869.

Thanks for the pointers. Happy for any PRs, but will see, that I get finally some time to put more time back into Syna in the comings months.