olefredrik/FoundationPress

Missing closing LI's in pagination markup

pixelbrad opened this issue · 1 comments

How can this bug be reproduced?

  1. Step one
    Call pagination function

  2. Step two
    Inspect page source

  3. Step three
    Observe that classless LI's are missing their closing LI tags.

What did you expect to happen?

I expected closing LI tags to be present for all LI's.

What happened instead?

Closing LI tags are missing on classless LI tags.

Expected markup:

<ul class="pagination text-center">
	<li class="current" aria-current="page"><span class="show-for-sr">You're on page </span>1</li>
	<li><a href="http://localhost:3000/blog/page/2/" aria-label="Page 2">2</a></li>
	<li><a href="http://localhost:3000/blog/page/3/" aria-label="Page 3">3</a></li>
	<li><a href="http://localhost:3000/blog/page/4/" aria-label="Page 4">4</a></li>
	<li><a href="http://localhost:3000/blog/page/5/" aria-label="Page 5">5</a></li>
	<li><a href="http://localhost:3000/blog/page/6/" aria-label="Page 6">6</a></li>
	<li class="ellipsis" aria-hidden="true"></li>
	<li><a href="http://localhost:3000/blog/page/10/" aria-label="Page 10">10</a></li>
	<li class="next"><a href="http://localhost:3000/blog/page/2/" aria-label="Next page"><i class="fas fa-angle-right"><span class="show-for-sr">Next page</span></i></a></li>
</ul>

Actual markup:

<ul class="pagination text-center">
	<li class="current" aria-current="page"><span class="show-for-sr">You're on page </span>1</li>
	<li><a href="http://localhost:3000/blog/page/2/" aria-label="Page 2">2</a>
	<li><a href="http://localhost:3000/blog/page/3/" aria-label="Page 3">3</a>
	<li><a href="http://localhost:3000/blog/page/4/" aria-label="Page 4">4</a>
	<li><a href="http://localhost:3000/blog/page/5/" aria-label="Page 5">5</a>
	<li><a href="http://localhost:3000/blog/page/6/" aria-label="Page 6">6</a>
	<li class="ellipsis" aria-hidden="true"></li>
	<li><a href="http://localhost:3000/blog/page/10/" aria-label="Page 10">10</a>
	<li class="next"><a href="http://localhost:3000/blog/page/2/" aria-label="Next page"><i class="fas fa-angle-right"><span class="show-for-sr">Next page</span></i></a></li>
</ul>

Please List the Following:

  • OS & version: N/A
  • Node version (node -v) [Node v6+ is required] : N/A
  • FoundationPress version (see line 3 in package.json): 2.10.6
  • Foundation version (found in node_modules/foundation-sites/package.json) : N/A

Include Test Case (if applicable):
N/A

The PR that fixes this issue has been merged. Not sure why this issue wasn't automatically closed. Closing it now.