oligot/rollup-plugin-nodent

Upgrade acorn-dynamic-import dependency

marvinhagemeister opened this issue · 2 comments

marvinhagemeister commented

One of the dependencies of this library is acorn-dynamic-import which depends on an older version of acorn. This causes problems when used together with newer acorn plugins that depend on acorn v6.

rollup-plugin-nodent is used in microbundle where we were running into exactly this issue: developit/microbundle#74

Upgrading acorn-dynamic-import locally fixes the issue.

I'm happy to make a PR myself but looking at the content of yarn.lock it seems like a custom npm registry mirror is used and I don't have access to it.

oligot commented

As discussed in MatAtBread/nodent#114, nodent-compiler still relies on Acorn v5 so I think that upgrading acorn-dynamic-import is sadly not enough.

oligot commented

Thanks to your comment, I've removed the custom registry in yarn.lock.

  • 👍1