React as peer dependency

Question

React as peer dependency

Closed this issue 8 years ago · 4 comments

danielstreit commented 8 years ago

Thanks for the project, this is a great idea!

Should react be added as a peer dependency to the package.json?

Answer 1 · 2016-10-10T19:33:03.000Z

Yeap, we could. We mostly depend on the React component hooks.
I believe we support a wide range of React versions.

Answer 2 · 2016-10-10T19:53:25.000Z

Yeah, looks like the component itself should work on any version of React.

The react-addons-shallow-compare has a peer dependency on react being the same version or higher than the addon package itself.

So...maybe it doesn't make sense to add a specific React peer dependency because it is included by the addon?

Answer 3 · 2016-10-10T20:22:12.000Z

So...maybe it doesn't make sense to add a specific React peer dependency because it is included by the addon?

I would rather be explicit with a peerDependency. Do you want to submit a PR?

Answer 4 · 2016-10-10T21:06:21.000Z

I looked into this a little more, and I think npm handles unresolved peerDependencies of dependencies pretty well. There should be no need to add react as a peerDependency here. Closing.