oliviertassinari/react-swipeable-views

Implement containerClassName

Closed this issue · 3 comments

PeterKottas commented
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

There should be a prop called containerClassName, to keep consistency with existing slideClassName

Current Behavior

This is not implemented

PeterKottas commented

Sorry, @oliviertassinari opened the issue by mistake before it was finished. This can be reopened now.

PeterKottas commented

My bad, it's implemented but called className and it's only mentioned after the api reference on https://react-swipeable-views.com/api/api/. What threw me off is that style for the container is called containerStyle but class for the container is just className. Little inconsistency never killed anybody I guess. Maybe something to look into but considering it would be a breaking change, I doubt this would be worth it.

oliviertassinari commented

@PeterKottas We don't expose this API because we need to inspect the style of containerStyle.

  • 👍1