oliviertassinari/react-swipeable-views

Could not find module in path: 'dom-helpers/transition/properties'

Closed this issue · 11 comments

repl-sean-heintz commented
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

Clean installation of react-swipeable-views can be used with the example from the README.

Current Behavior

ModuleNotFoundError
Could not find module in path: 'dom-helpers/transition/properties' relative to '/node_modules/react-swipeable-views/lib/SwipeableViews.js'

Seems to have been introduced by #556

Steps to Reproduce (for bugs)

https://codesandbox.io/s/dreamy-euler-xifo5

Context

We had to lock our version of react-swipeable-views to a previous version to fix our build.

Your Environment

Tech Version
react-swipeable-views 0.13.4
React 16.12.0
vanhoutenbos commented

Hi,

Thank you for your report, i will try to take a look at this tomorrow morning.
We just created a release for version 0.13.4 but have unfortunatly not gotten around to testing it due to personal obstructions.

I will let you know when we fixed the issue

repl-sean-heintz commented

@jeanpoelie I've opened a PR which addresses the issue, please take a look when you've got time. Cheers!

vanhoutenbos commented

I have checked and merged the PR, i will need to do a new release but have some issues due to me being on a windows pc and not having the option to use rm which is only available on mac

raduchiriac commented

This issue still persist on 0.13.6. Anyone else?

  • 👍9
vanhoutenbos commented

I have reopened it, i will be rolling back 2 PRs they seem to cause this issue

yanickrochon commented

No idea why this was closed. I just updated and got this error.

oliviertassinari commented

Are you using the latest release?

yanickrochon commented

@oliviertassinari if you mean by "latest release" to install via "yarn add react-swipeable-views@0.13.8" then, yes, I tried the latest release. Going back to 0.13.4 did not help either, so I finally reinstalled 0.13.3 and it worked again.

In other words, I can't upgrade this module because it breaks my app otherwise.

oliviertassinari commented

@yanickrochon Something is off in your env, proof: https://codesandbox.io/s/x8x11zjmp.

yanickrochon commented

Well, since it works with 0.13.3, and not with any other, what did change?

oliviertassinari commented

@yanickrochon Hopefully it will work for your project in the next release :).