olsh/Feedly-Notifier-Firefox

Button not showing up

Brawl345 opened this issue · 17 comments

Hello,
the feedly button doesn't show up. It worked earlier, but now the button isn't there and notifications also don't work. I checked the customize menu, but the icon isn't there :(
I'm on Firefox 31 on Ubuntu 14.04 x64.

olsh commented

Hello,
Have you tired to create a new Firefox profile?

I've created a new profile and tried some things. I know the problem:
I've installed "Classic Theme Restorer" and when the option "show favorite star in adressbar" is ticked, the feedly notifier button vanishes. This is odd. Anyway, I disabled this option and now the button is there again and notifications work!
and btw.: the button looks odd on Linux, but this is another bug.
bildschirmfoto vom 2014-07-25 15 46 25

The button also looks like that to me in Linux.
It's normal in Windows though.

olsh commented

I'm aware about this bug.
I'm awaiting a new API for toolbar buttons, when it will be released, I'll fix the bug.

olsh commented

There is the issue regarding the API. You can vote for this! :)

I've been having an issue forever where the button disappears. I reported it a few versions ago and that to fix it I had to go into options and disable/re-enable "Show counter". The underlying issue seems to have never been fixed. Most the time when I restart Firefox it the button is gone. I see issue was acknowledged 4 days ago but since I've been having it for months I'm not sure if it's exactly the same cause...

I had the same problem. Do you have Classic Theme Restorer or similiar extensions installed? Check the third comment.

I don't. I even tried disabling all my other add-ons and this issue still occurred. I should correct myself though, it doesn't ALWAYS happen....just like 70% of the time.

olsh commented

I see issue was acknowledged 4 days ago but since I've been having it for months I'm not sure if it's exactly the same cause...

This issue was discovered when Australis UI was released. Ok, I'll explain in details.

The addon was written with Addon-SDK, and there was only one way to add button to the browser toolbar, it's the widget api. And all was fine until Australis UI.

After the Australis UI was released, they announced a new API for creating icons on the browser toolbar and the widget API was marked as deprecated (not recommended for using in Firefox 29+). Since this moment bugs began to appear, because the addon are using deprecated APIs.

Maybe do you ask: why I'm not using the new API?
In a nutshell: the new API does not support badges. And there is issue in Bugzilla and even a pull request which implements the badges on the icons. When the pull request will be applied and new version of Addon-SDK will be released, I'll immediately rewrite the Feedly Notifier. And I'm almost sure it'll solves all bugs regarding the toolbar icon.

If you have any suggestions let me know.

I will wait for the Addons SDK update.
I am experiencing the issue for a long time :(

olsh commented

Great news! But it seems like, the pull request is not merged yet. When it will be merged, I'll create version with the new API.

The pull request got merged! yay! I think we must wait for a new version of the add-on sdk?

olsh commented

I've built the version which uses the new badge API. I hope all bugs are gone away. :)
The version is compatible only with Firefox 36(currently it is Nightly) and later.

Please test it and let me know if you find new bugs, thank you!

Thanks, but the button is still not there. When I have an add-on which modifies the url bar (such as "enable star" option in Classic Theme Restorer or RSS feed icon in Navbar add-on), the button disappears after a restart and isn't shown on about:customizing

EDIT: I don't think it's a bug in the add-on but in firefox. Because the symbol for "Ghostery" also disappears, but it is addable

olsh commented

Are you using FF36?
Maybe there is incompatibility with CTR or maybe it is because the API is an experimental or because Nightly is not stable. Too many reasons.

btw, I've just installed the CTR and enable the same options as you, but all works fine after restart.

olsh commented

The new version has been released.
I hope it'll fixes all these icon related problems.

Feel free to reopen the issue.