omariosouto/animusjs

Maybe is not good use world to reference the Window Object

woliveiras opened this issue · 1 comments

woliveiras commented

Maybe is not good use world namespace to reference the Window Object because is a "convention" name the object as win, and Document Object as doc or even not rename them.

In this line:

https://github.com/soutomario/animusjs/blob/master/src/animus.js#L1

Look: https://toddmotto.com/what-function-window-document-undefined-iife-really-means/

In some lines you use window and in others use world:

Is good make a pattern in the project.

omariosouto commented

Thanks by the tip =D
Now it's everything okay!

  • 👍1