omarryhan/aiogoogle

Issue with `ServiceAccountCreds` with `universe_domain`

Closed this issue · 2 comments

a-fellow-human commented

Hello, it appears that ServiceAccountCreds doesn't seem to have an option to add a universe_domain. Importantly, this means that if you run

ServiceAccountCreds(scopes=scopes, **service_account_key)

with a service account key auto-generated by Google, the code will fail with error

TypeError: __init__() got an unexpected keyword argument 'universe_domain'

A simple workaround would be to simply remove the universe_domain line from the JSON key.

Other libraries such as google-auth already implement adding universe_domain.

omarryhan commented

Hello, thanks for filing the feature request. I'd be very happy to review a PR that implements it and release a new version. I don't have the time to work on implementing this feature unfortunately. Thanks

ryanlewist commented

@a-fellow-human I also had this issue but I just removed universe_domain from my service account key object, and then forgot about it. But I saw that you raised the issue, I decided to do something about it, and it is now resolved!

  • 🎉1