final project feedback
Opened this issue · 0 comments
lvreynoso commented
Hi Omar! I've graded your final project and have some feedback for you:
- good job implementing your Dictogram and Listogram classes and passing all unit tests; please don't delete tests, especially when they're important (like the sampling test you removed)
- good job with your sampling methods in the Dictogram class; I'm not sure why you renamed it, this only made it more tedious to test it
- Listogram needs a sampling method
- good job implementing a >2nd order Markov chain
- good job deploying your app to heroku and implementing buttons
- decent code comments