omeka-s-modules/ItemCarouselBlock

When multiple slides show simultaneously, images can extend beyond their container

Closed this issue · 6 comments

matthewjmckinley commented

I'm not able to recreate this... could you share your settings, and maybe the dimensions of the image that's breaking the container?

kimisgold commented

I suspect it has to do with that first image. It's 1996x840.

image

sharonmleon commented

@matthewjmckinley @kimisgold Any thoughts on a fix here?
(This is final outstanding issue on this module.)

matthewjmckinley commented

I don't think I ever was able to reproduce this one. I'm testing now with multiple images larger than 1996x840, and it's resizing them fine with 2, 3, 4, etc. items for page. I may have tweaked the CSS to handle this better at some point? @kimisgold is this still happening for you or can we consider this fixed?

kimisgold commented

This is happening in the following themes:

  • Center Row
  • The Daily
  • Cozy

The themes where this isn't happening have max-width: 100% set on all images by default.