Version 3.0 throws error with MediaWiki ver 1.39.2 - getParentRevisionId () depreciated

Question

Version 3.0 throws error with MediaWiki ver 1.39.2 - getParentRevisionId () depreciated

Opened this issue 2 years ago · 6 comments

I am wondering if it was known that using Scripto 3.0 with the newest version of MediaWiki ver 1.39.2 throws an error when a saves a page when transcribing an object. The error pointed to not being able to retrieve getParentRevisionID() as it seems to have been depreciated. However, we noticed that Scripto is working fine with one version back, at 1.39.1.

Here's the detailed error we saw when we were using MediaWiki 1.39.2 with Scripto 3.0

MediaWiki\Content\ValidationParams::getParentRevisionId ()
depreciated since 1.38.
https://doc.wikimedia.org/mediawiki-core/master/php/classMediaWiki_1_1Content_1_1ValidationParams.html#a4b5b3fc93fbb42013421d55dc245c725

We aren't able to upgrade to Scripto 4.0 yet, as we don't have Omeka 4.0 installed, but I'm wondering if this issue would be resolved in Scripto 4.0?

Answer 1 · 2023-03-01T16:41:18.000Z

You're the second person who has reported this problem (see here). I can't reproduce on MediaWiki (1.39.2) on either Omeka/Scripto (3.2.3/1.3.0) or the most recent Omeka/Scripto (4.0.1/1.4.0), which makes it difficult for me to troubleshoot. It's even more strange that Scripto doesn't do anything particularly interesting when making an edit request against MediaWiki's API. The error seems to occur at a lower level than the API, several degrees of separation from Scripto. It's almost like this is a regression in MediaWIki.

Can you walk me through the exact steps it takes for you to get the error?

Answer 2 · 2023-03-01T18:06:26.000Z

After looking at this further, the actual error is "Class MediaWiki\Content\ValidationParams not found", not that getParentRevisionId() is deprecated. Is it possible that you're missing the /includes/content/ValidationParams.php file?

Answer 3 · 2023-03-01T19:53:22.000Z

Hey there. Actually, that was me who reported this in the Omeka forum. I took a look to make sure that we have the ValidationParams.php file and we do.

What happened before was simply that a logged in user would input some text in the transcription area of a page and upon hitting the "save" button, it would throw the error that I posted above. Here's a screen shot of what our page looks like with the URL of a logged in user.

It's good to know that it has nothing to do with the getParentRevisionID(), and that makes sense since we are able to get it working in version 1.39.1. I actually have a test / dev server of which I'm trying to recreate the error right now with Scripto 3.0 and the newest version of MediaWiki and for some reason I cannot recreate it.

Answer 4 · 2023-03-01T20:35:01.000Z

I wonder, when you were on 1.39.2 could that file have been missing? Wasn't sure if that's what you checked on just now, or if you were looking at the (working) 1.39.1 install.

Answer 5 · 2023-03-01T20:36:25.000Z

Also, verify that /includes/content/ValidationParams.php contains the ValidationParams class.

Answer 6 · 2023-03-01T21:46:53.000Z

Yes, both our test instance on ver 1.39.2 and the live 1.39.1 versions have the ValidationParams class and both files look the same. That's a good point, as to whether our live instance was originally missing the file. That I cannot check on now.

pageIdentity = $pageIdentity; $this->flags = $flags; $this->parentRevId = $parentRevId; } /** * * @return PageIdentity */ public function getPageIdentity(): PageIdentity { return $this->pageIdentity; } /** * * @return int */ public function getFlags(): int { return $this->flags; } /** * @deprecated since 1.38. Born soft-deprecated as we will move usage of it * to MultiContentSaveHook in ProofreadPage (only one place of usage). * * @return int */ public function getParentRevisionId(): int { return $this->parentRevId; } }